refactor(@angular/cli): integrate MCP roots into Host abstraction#33090
Merged
dgp1130 merged 1 commit intoangular:mainfrom Apr 30, 2026
Merged
refactor(@angular/cli): integrate MCP roots into Host abstraction#33090dgp1130 merged 1 commit intoangular:mainfrom
dgp1130 merged 1 commit intoangular:mainfrom
Conversation
clydin
force-pushed
the
refactor/mcp-roots-integration
branch
from
960270e to
08b674d
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements path restriction for the MCP host by introducing a createRootRestrictedHost wrapper and updating the Host interface with a setRoots method. The MCP server now dynamically manages these roots based on client capabilities and notifications. Review feedback suggests enhancing the security of the path validation logic to prevent bypasses via glob patterns or command paths and recommends refactoring the server initialization to use an async handler instead of an IIFE.
clydin
force-pushed
the
refactor/mcp-roots-integration
branch
6 times, most recently
from
e11994e to
6ff5f8b
Compare
Update the `Host` abstraction to be aware of allowed roots provided by the MCP client. A new `createRootRestrictedHost` wrapper enforces that file operations and command executions stay within these roots. The server is updated to initialize roots on connection and listen for changes.
clydin
force-pushed
the
refactor/mcp-roots-integration
branch
from
6ff5f8b to
d4cdb0c
Compare
clydin
added
target: patch
alan-agius4
approved these changes
Apr 30, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
Hostabstraction to be aware of allowed roots provided by the MCP client. A newcreateRootRestrictedHostwrapper enforces that file operations and command executions stay within these roots. The server is updated to initialize roots on connection and listen for changes.