Improve threading termination and queue handling#3094
Merged
MMathisLab merged 3 commits intomainfrom Sep 18, 2025
Merged
Conversation
queue.Full errors by blocking producer during model warm-upqueue.Full errors by blocking producer during model warm-up
c9f16fb to
7a7a9ff
Compare
queue.Full errors by blocking producer during model warm-up
Contributor
|
Thanks for this. LGTM. |
MMathisLab
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request improves the robustness of the multithreading in the inference pipeline.
Changes:
_safe_putand_safe_gethelper methods to handleQueueoperations safely._stop_event, ensuring proper shutdown even if one thread crashes or the user interrupts execution (e.g., Ctrl-C).queue.Fullerrors that could occur during model cold start or if the consumer is temporarily slow (reported here, happened to me on rare occasions as well).None) are enqueued safely without risk of blocking.Impact:
queue.Fullerrors during asynchronous inference, even with large models or slower hardware.