Fix: properly use unique_bodyparts and identity_scores arguments in ShelfWriter.add_prediction#3112
Merged
deruyter92 merged 10 commits intomainfrom Feb 19, 2026
Merged
Fix: properly use unique_bodyparts and identity_scores arguments in ShelfWriter.add_prediction#3112deruyter92 merged 10 commits intomainfrom
unique_bodyparts and identity_scores arguments in ShelfWriter.add_prediction#3112deruyter92 merged 10 commits intomainfrom
Conversation
2 tasks
Contributor
|
LGTM. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where unique_bodyparts and identity_scores arguments in ShelfWriter.add_prediction() were being overwritten with None by redundant kwargs.get() calls, causing the method to ignore valid direct arguments.
Changes:
- Removed two lines that were reassigning
unique_bodypartsandidentity_scoresparameters with values fromkwargs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deruyter92
approved these changes
Jan 15, 2026
Collaborator
|
Maybe add a unit test for this specifically @deruyter92 ? |
Collaborator
|
Added unit tests, which revealed another bug in writing metadata. Now addressed that as well.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in PR #2861 and reported in Issue #3108, where the
unique_bodypartsandidentity_scoresarguments inShelfWriter.add_prediction()were being overwritten withNonedue to redundantkwargs.get()calls.These reassignments caused the method to ignore valid input arguments when passed directly. The fix removes the two lines that overwrote these parameters, restoring the correct behavior while keeping
**kwargsin the signature for subclass compatibility.