Filled in missing Documentation for Heatmap, Marks(Pie), Marks(market), scales, axes etc. Considered previous style and matched it correctly#1696
Open
ishaan-cherukuri wants to merge 1 commit intobqplot:masterfrom
Conversation
martinRenou
reviewed
Apr 27, 2026
Member
There was a problem hiding this comment.
I suppose this was committed by mistake?
Member
|
That's amazing thanks! I'll give this a review |
martinRenou
requested changes
Apr 27, 2026
Member
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Thanks a ton, apart from one comment + the unwanted commited files that's good to go
| opacity_slider = widgets.FloatSlider(value=1.0, min=0.0, max=1.0, step=0.05, | ||
| description="Opacity") | ||
| # jslink works on simple scalar traits | ||
| widgets.jslink((opacity_slider, "value"), (fig, "fig_margin")) # example only |
Member
There was a problem hiding this comment.
I know it's only an example, but it is likely incorrect, fig_margin is not a scalar value but a dictionary like dict(top=60, bottom=100, left=60, right=60)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Code changes
User-facing changes
Backwards-incompatible changes