Skip to content

fix(site): fix OpensAdminSubPanelOnMobile story on mobile viewport#24678

Merged
johnstcn merged 2 commits intomainfrom
fix/opens-admin-subpanel-mobile-story
Apr 23, 2026
Merged

fix(site): fix OpensAdminSubPanelOnMobile story on mobile viewport#24678
johnstcn merged 2 commits intomainfrom
fix/opens-admin-subpanel-mobile-story

Conversation

@johnstcn
Copy link
Copy Markdown
Member

@johnstcn johnstcn commented Apr 23, 2026

OpensAdminSubPanelOnMobile story has been failing due to not finding a role="link" with name "Settings".

Agent investigated and claimed the Settings icon gets hidden in mobile view.
Suggested fix is to start the story directly at /agents/settings.

Generated with Coder Agents

On mobile viewport the sidebar gear icon is inside a hidden container
(hidden md:block), so openSettingsView cannot find a link with name
Settings. Start the story at /agents/settings directly instead.
@johnstcn johnstcn self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Member Author

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-reviewed

@johnstcn johnstcn marked this pull request as ready for review April 23, 2026 16:22
Comment thread site/src/pages/AgentsPage/AgentsPageView.stories.tsx Outdated
Comment thread site/src/pages/AgentsPage/AgentsPageView.stories.tsx Outdated
@johnstcn johnstcn enabled auto-merge (squash) April 23, 2026 16:35
@johnstcn johnstcn merged commit 7efccfa into main Apr 23, 2026
25 of 27 checks passed
@johnstcn johnstcn deleted the fix/opens-admin-subpanel-mobile-story branch April 23, 2026 16:41
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants