fix(Makefile): run storybook tests after Go tests in pre-push#24703
Merged
fix(Makefile): run storybook tests after Go tests in pre-push#24703
Conversation
Rolldown's tokio workers stall when competing with Go compilation and the production site build for CPU, causing Vite transform requests to hang. Vitest browser mode has no import-phase timeout, so a stalled browser import() blocks the run indefinitely.
mafredri
force-pushed
the
mafredri/fix-pre-push-storybook-hang
branch
from
2b1712c to
a715575
Compare
mafredri
changed the title
johnstcn
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolldown's tokio workers stall when competing with Go compilation and the production site build for CPU, causing Vite transform requests to hang. Vitest browser mode has no import-phase timeout, so a stalled browser
import()blocks the run indefinitely.Work-around: run storybook tests after the parallel Go/JS/build targets finish.
Diagnostic evidence
(0 test)after 7+ min. Vitest sleeping inep_poll, 68 CLOSE-WAIT sockets, one ESTAB request Vite never serves. Example victim:Breadcrumb.stories.tsx(trivial static component)./proc/<pid>/task/.ss -tnpshows the stuck file's module request sitting ESTAB in Vite's socket table.