<ranges>: improve views::istream constraints#3335
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jan 12, 2023
Merged
<ranges>: improve views::istream constraints#3335StephanTLavavej merged 1 commit intomicrosoft:mainfrom
<ranges>: improve views::istream constraints#3335StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
`views::istream<T>::operator()` currently emits "hard" errors when its argument is correctly `derived_from` a specialization of `basic_istream` but any of the other requirements isn't satisfied. This is non-conforming, since the CPO wording requires CPOs not to participate in overload resolution for sets of arguments that don't meet the CPOs requirements. Let's flesh out the constraints, and add some negative test cases to ensure we get SFINAE instead of hard errors.
StephanTLavavej
approved these changes
Jan 10, 2023
strega-nil-ms
approved these changes
Jan 10, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
views::istream<T>::operator()currently emits "hard" errors when its argument is correctlyderived_froma specialization ofbasic_istreambut any of the other requirements isn't satisfied. This is non-conforming, since the CPO wording requires CPOs not to participate in overload resolution for sets of arguments that don't meet the CPOs requirements.Let's flesh out the constraints, and add some negative test cases to ensure we get SFINAE instead of hard errors.