This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Perl readline creates empty sys$command files if no STDIN is connected#152
Merged
dscho merged 1 commit intomsysgit:masterfrom Jan 3, 2014
csware:syscommand
Merged
Perl readline creates empty sys$command files if no STDIN is connected#152dscho merged 1 commit intomsysgit:masterfrom csware:syscommand
dscho merged 1 commit intomsysgit:masterfrom
csware:syscommand
Conversation
This was originally reported to TortoiseGit: http://code.google.com/p/tortoisegit/issues/detail?id=1011 This patch was also reported to MinGW (http://sourceforge.net/p/mingw/patches/506/) and upstream perl (https://rt.perl.org//Public/Bug/Display.html?id=115900) where it was finally accepted and applied (to version 5.18). Signed-off-by: Sven Strickroth <email@cs-ware.de>
Closed
Member
|
This looks good to me. |
dscho
added a commit
that referenced
this pull request
Jan 3, 2014
Perl readline creates empty sys$command files if no STDIN is connected
Member
|
Thanks! @csware this was excellent, thank you, you made it easier for me to take the pull request than not to take it ;-) |
|
Unfortunately this should have been made also as a patch in |
dolmen
added a commit
to dolmen/msysgit
that referenced
this pull request
Apr 26, 2014
Add patch for Term::ReadLine. msysgit#61 (comment) This patch has been directly applied to /lib/perl5/5.8.8 in db8d1bf (see msysgit#152) In this commit, the patch is put in /src/perl/patches to be applied on top of the perl 5.8.8 source to allow a clean rebuild. As the fix has been integrated in upstream in perl 5.18, it will not have to be ported when upgrading perl.
dscho
pushed a commit
that referenced
this pull request
May 18, 2014
Add patch for Term::ReadLine. #61 (comment) This patch has been directly applied to /lib/perl5/5.8.8 in db8d1bf (see #152) In this commit, the patch is put in /src/perl/patches to be applied on top of the perl 5.8.8 source to allow a clean rebuild. As the fix has been integrated in upstream in perl 5.18, it will not have to be ported when upgrading perl. [JES: wrapped the commit message as per guide lines] Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally reported to TortoiseGit: http://code.google.com/p/tortoisegit/issues/detail?id=1011
This patch was also reported to msysgit (https://groups.google.com/forum/#!topic/msysgit/oHDBhnAHIe4), MinGW (http://sourceforge.net/p/mingw/patches/506/) and upstream perl (https://rt.perl.org//Public/Bug/Display.html?id=115900) where it was finally accepted and applied (to version 5.18).
It was already reported one year ago (https://groups.google.com/forum/#!topic/msysgit/oHDBhnAHIe4 and #61 (comment)).
#61 (comment) states that I should create a PR, so I do.