[ticket/17600] Add mark notifications read to controllers#6923
Open
rubencm wants to merge 1 commit intophpbb:masterfrom
Open
[ticket/17600] Add mark notifications read to controllers#6923rubencm wants to merge 1 commit intophpbb:masterfrom
rubencm wants to merge 1 commit intophpbb:masterfrom
Conversation
rubencm
force-pushed
the
ticket/17600
branch
4 times, most recently
from
242dd9e to
b4ce937
Compare
rubencm
force-pushed
the
ticket/17600
branch
2 times, most recently
from
d845ba4 to
5baf86c
Compare
rubencm
force-pushed
the
ticket/17600
branch
3 times, most recently
from
b7a974c to
143efb3
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds dedicated notification controllers/routes for “mark read” actions, and updates forum/index pages to use them instead of handling mark-read logic inline.
Changes:
- Introduces new controllers + routes for marking all forums, subforums, and forum topics as read
- Updates
index/viewforum/ forum list links to use controller routes - Refactors forum/forum-list SQL into new helper functions (
get_forum_data,get_forums_rows)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| phpBB/viewforum.php | Uses get_forum_data() and routes “mark topics read” through the controller |
| phpBB/phpbb/notification/controller/mark_topics_read.php | New controller endpoint for marking topics in a forum as read |
| phpBB/phpbb/notification/controller/mark_subforums_read.php | New controller endpoint for marking subforums as read |
| phpBB/phpbb/notification/controller/mark_all_read.php | New controller endpoint for marking everything read from index |
| phpBB/phpbb/forum/controller/index.php | Updates “mark forums read” link to point at the new notifications route |
| phpBB/includes/functions_display.php | Removes inline mark-read handling; generates controller route links for mark-read |
| phpBB/includes/functions.php | Adds get_forums_rows() / get_forum_data() helpers; updates markread() phpdoc types |
| phpBB/config/default/routing/notifications.yml | Registers routes for the new mark-read controllers |
| phpBB/config/default/container/services_notification.yml | Registers services for the new controllers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rubencm
force-pushed
the
ticket/17600
branch
3 times, most recently
from
a729e0a to
dd54cba
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPBB-17600
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17600