Finish PR 4051 - Make forall keyword optional in instance declaration#4187
Closed
JordanMartinez wants to merge 6 commits intopurescript:masterfrom
JordanMartinez:fix-1120
Closed
Finish PR 4051 - Make forall keyword optional in instance declaration#4187JordanMartinez wants to merge 6 commits intopurescript:masterfrom JordanMartinez:fix-1120
JordanMartinez wants to merge 6 commits intopurescript:masterfrom
JordanMartinez:fix-1120
Conversation
Contributor
Author
|
Sigh.. I was hoping to work on this more, but |
Contributor
Author
|
I got First, I'll be out for the next two weeks or so on vacation-related things. So, I'm not going to get to this anytime soon. Second, implementing this properly will likely touch the type checker, which I'm still unfamiliar with. So, when I do get back, I'd rather focus my efforts on understanding the compiler deeply, and then continue my efforts here. I will reopen once I've made progress or have further questions about how to proceed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Builds off #4051. Fixes #1120. Currently a WIP. I've only handled the merge conflict so far.
Checklist: