Skip to content

Finish PR 4051 - Make forall keyword optional in instance declaration#4187

Closed
JordanMartinez wants to merge 6 commits intopurescript:masterfrom
JordanMartinez:fix-1120
Closed

Finish PR 4051 - Make forall keyword optional in instance declaration#4187
JordanMartinez wants to merge 6 commits intopurescript:masterfrom
JordanMartinez:fix-1120

Conversation

@JordanMartinez
Copy link
Copy Markdown
Contributor

Description of the change

Builds off #4051. Fixes #1120. Currently a WIP. I've only handled the merge conflict so far.


Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

Sigh.. I was hoping to work on this more, but haskell-language-server isn't working anymore in my local copy of this repo.

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

I got haskell-language-server to work again. However, I'm going to close this for the time being for two reasons.

First, I'll be out for the next two weeks or so on vacation-related things. So, I'm not going to get to this anytime soon.

Second, implementing this properly will likely touch the type checker, which I'm still unfamiliar with. So, when I do get back, I'd rather focus my efforts on understanding the compiler deeply, and then continue my efforts here. I will reopen once I've made progress or have further questions about how to proceed.

@JordanMartinez JordanMartinez deleted the fix-1120 branch May 14, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow forall in polymorphic instance heads

2 participants