fix: reduce re-registration interval to 5s to prevent replica staleness flapping#24597
Merged
fix: reduce re-registration interval to 5s to prevent replica staleness flapping#24597
Conversation
…a staleness flapping
…a staleness flapping
spikecurtis
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace proxies re-register with the primary coderd every 15 seconds, which updates their replica row's updated_at timestamp in the database. The primary's replicaManager considers any replica not updated within 3 × 5s = 15s as stale and excludes it from queries.
So we basically get one shot at registering before being marked stale and breaking DERP meshing to this replica. Was causing some very confusing failures when scaletesting.