Skip to content

fix: reduce re-registration interval to 5s to prevent replica staleness flapping #24597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sreya merged 3 commits into from
Apr 24, 2026
+4 −1
Merged

fix: reduce re-registration interval to 5s to prevent replica staleness flapping #24597

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
941568f
fix(wsproxy): reduce re-registration interval to 5s to prevent replic…
sreya Apr 21, 2026
1aedda6
fix(wsproxy): reduce re-registration interval to 5s to prevent replic…
sreya Apr 21, 2026
c3ddb26
update comment
sreya Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion enterprise/wsproxy/wsproxysdk/wsproxysdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,11 @@ func (l *RegisterWorkspaceProxyLoop) register(ctx context.Context) (RegisterWork
// Start starts the proxy registration loop. The provided context is only used
// for the initial registration. Use Close() to stop.
func (l *RegisterWorkspaceProxyLoop) Start(ctx context.Context) (RegisterWorkspaceProxyResponse, error) {
// Workspace proxy re-registrations should be on the same interval as the rest of the replicasync.
// If they differ significantly it can cause problems with meshing.
if l.opts.Interval == 0 {
l.opts.Interval = 15 * time.Second
// Default to the same interval as the rest of the replicasync.
l.opts.Interval = 5 * time.Second
}
if l.opts.MaxFailureCount == 0 {
l.opts.MaxFailureCount = 10
Expand Down
Loading